Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow smart case in global search #781

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Allow smart case in global search #781

merged 1 commit into from
Sep 24, 2021

Conversation

pppKin
Copy link
Contributor

@pppKin pppKin commented Sep 23, 2021

As suggested in #777 , smart case option is now passed to RegexMatcherBuilder in global_search.

pickfire
pickfire approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Not tested.

@sudormrfbin sudormrfbin linked an issue Sep 23, 2021 that may be closed by this pull request
Make Global Search use the new Smart Case Search enhancement #777
Closed
@archseer archseer merged commit 432bec1 into helix-editor:master Sep 24, 2021
@pppKin pppKin deleted the global_search_smart_case branch October 11, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

@pickfire pickfire pickfire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Global Search use the new Smart Case Search enhancement
3 participants
@pppKin @archseer @pickfire