Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect non-existent files as non-readonly #7875

Conversation

the-mikedavis
Copy link
Member

Previously all files not backed by an existing file (:open does-not-exist.txt) would be marked as readonly in the new read-only-indicator statusline element (#7740).

Previously all files not backed by an existing file
(`:open does-not-exist.txt`) would be marked as readonly in the new
read-only-indicator statusline element.
@the-mikedavis the-mikedavis added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer. labels Aug 8, 2023
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pascalkuthe pascalkuthe added this to the next milestone Aug 8, 2023
@archseer archseer merged commit f01ca10 into helix-editor:master Aug 8, 2023
6 checks passed
@the-mikedavis the-mikedavis deleted the read-only-indicator/mark-new-files-as-writable branch August 8, 2023 19:24
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants