make sure to sync views when applying edits to unfocused views #9173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can also confirm it fixes a bug similar to the one in the discussion but with renaming.where you open a document (a) then create a split and go to near the end of the file there, then change to a different document(b) that has a function you can rename that is referenced in file (a), then go to file (a) in the other split find the reference to the function you are going to rename and delete from the line after there to the end of the file, switch back to the other split with file (b) and rename the function, before this pr helix crashes there |
pascalkuthe
reviewed
Dec 26, 2023
this fixes bugs when applying workspace edits with lsp to a view where the most recent selection range is outside the current document or when adding a newline/formatting during write all in the same situation
|
I moved it to editor, needed to change some things to appease the borrow checker stuff |
pascalkuthe
approved these changes
Jan 7, 2024
pascalkuthe
added
C-bug
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes bugs when applying workspace edits with lsp to a view where the most recent selection range is outside the current document or when adding a newline/formatting during write all in the same situation
fixes #9157 and fixes #6752
I decided to sync the view when getting the id instead of calling sync when applying the transaction. I am not sure if I put the utility function in the correct place, I did have to take the tree instead of the editor because rust was giving me error for passing the editor within the closure in write-all, which I wasnt able to figure out
(I think we might be able to use this function in reload-all as well, though it already properly handles this)