Require Screenfull to be imported using require when using TypeScript

helloyutian · Sep 4, 2019 · 2664e56 · 2664e56
1 parent 9b98fcc
commit 2664e56
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 19 deletions.
diff --git a/dist/screenfull.d.ts b/dist/screenfull.d.ts
@@ -154,12 +154,7 @@ declare namespace screenfull {
 /**
 Simple wrapper for cross-browser usage of the JavaScript [Fullscreen API](https://developer.mozilla.org/en/DOM/Using_full-screen_mode), which lets you bring the page or any element into fullscreen. Smoothens out the browser implementation differences, so you don't have to.
 */
-declare const screenfull:
-	| (screenfull.Screenfull & {
-			// TODO: remove this in the next major version
-			default: typeof screenfull;
-	  })
-	| false;
+declare const screenfull: screenfull.Screenfull | false;
 
 export = screenfull;
 export as namespace screenfull;
diff --git a/dist/screenfull.js b/dist/screenfull.js
@@ -97,7 +97,7 @@
 			}.bind(this));
 		},
 		exit: function () {
-			return new Promise(function (resolve) {
+			return new Promise(function (resolve, reject) {
 				if (!this.isFullscreen) {
 					resolve();
 					return;
@@ -170,8 +170,6 @@
 
 	if (isCommonjs) {
 		module.exports = screenfull;
-		// TODO: remove this in the next major version
-		module.exports.default = screenfull;
 	} else {
 		window.screenfull = screenfull;
 	}

diff --git a/dist/screenfull.min.js b/dist/screenfull.min.js
diff --git a/src/screenfull.d.ts b/src/screenfull.d.ts
@@ -154,12 +154,7 @@ declare namespace screenfull {
 /**
 Simple wrapper for cross-browser usage of the JavaScript [Fullscreen API](https://developer.mozilla.org/en/DOM/Using_full-screen_mode), which lets you bring the page or any element into fullscreen. Smoothens out the browser implementation differences, so you don't have to.
 */
-declare const screenfull:
-	| (screenfull.Screenfull & {
-			// TODO: remove this in the next major version
-			default: typeof screenfull;
-	  })
-	| false;
+declare const screenfull: screenfull.Screenfull | false;
 
 export = screenfull;
 export as namespace screenfull;
diff --git a/src/screenfull.js b/src/screenfull.js
@@ -92,7 +92,7 @@
 			}.bind(this));
 		},
 		exit: function () {
-			return new Promise(function (resolve) {
+			return new Promise(function (resolve, reject) {
 				if (!this.isFullscreen) {
 					resolve();
 					return;
@@ -165,8 +165,6 @@
 
 	if (isCommonjs) {
 		module.exports = screenfull;
-		// TODO: remove this in the next major version
-		module.exports.default = screenfull;
 	} else {
 		window.screenfull = screenfull;
 	}