-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify chart change detection #80
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Floris van der Grinten <floris.vandergrinten@agilebits.com>
a1a695b
to
1a23f70
Compare
To avoid unwanted release attempts. More background in the upstream PR: helm/chart-releaser-action#80
I would prefer a chart diff for change detection, while also ensuring the chart version is different. I personally would like the diff appended to the release somehow as currently the details on what changed for a single chart between releases isn't easy to find when multiple charts exist in the same repository. |
👍 would prefer triggering new release only when the version number has changed. I keep getting myself into trouble by updating random files (e.g. making formatting adjustments to all READMEs in a repo), which then causes chart-releaser-action to try to release those charts and failing with the |
👍 I find the default approach to not work for me because I use a symlink and a submodule to the charts directory. So it doesn't correctly pick it up. This PR would fix that however; |
Me too. Did you find a solution for it ? |
I use a forked version of this repo https://github.com/zelic-io/charts/blob/main/.github/workflows/release.yml#L28 |
I ended up forking it and the make same changes as this PR. |
In the README it says:
When reading this, I expected this action to do an actual chart version check (using the standard
version
field in the respectiveChart.yaml
). But when looking at the code, it surprised me that this action decides for itself when a new version should be released, by doing a git diff.So when you merge to the configured branch, without necessarily expecting a release to be done, the action may still try to create a new release, which then results in:
Wouldn't it be simpler to just use the actual chart version for the chart-version check to determine whether to release?
I prototyped it in this PR and it works well (at least for my case).
Some caveats/things to note about the implementation:
release-name-template
of{{ .Name }}-{{ .Version }}
yq
andhelm
CLI