-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[incubator/cassandra-k8s-operator] Add charts for the Orange's Cassandra Kubernetes operator #14414
Conversation
Hi @allamand. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hey @allamand, Have you considered hosting this chart and adding it to helm hub? |
Hello @maorfr, actually I have nowhere to store the chart, so I thought it was better to add it in the helm/charts repository. |
@maorfr, can we run e2e tests on this, is it ok for you ? |
/ok-to-test sure, i'll let the tests run wdyt? |
I can take a look at github page, but I already use github pages for documentation sharing in the project. It seems to be at this time that it would be more useful in the charts repository but I'm open mind :) Regarding the tests, they are failing because the CRD is missing when testing the chart. In fact, I don't create the CRD in the helm willingly to avoid garbage collector of the CRD when deleting the chart. Any suggestion on how I should be doing that? thanks for help |
/approve |
Signed-off-by: sebastien allamand <sebastien.allamand@orange.com>
/retest |
Signed-off-by: sebastien allamand <sebastien.allamand@orange.com>
@maorfr I think It's Ready to merge. I would like to merge it in incubator/charts, and I will work in future to have the charts on our own repo. Is that ok for you ? |
@obeyler: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @jlegrone |
/assign @prydonius |
I think that's fine for now. Just bear in mind that in the future we want to move towards a more distributed model, so folks will run their own chart repositories and add them to the Helm Hub (https://hub.helm.sh). /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: allamand, obeyler, prydonius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…dra Kubernetes operator (helm#14414) * Add Cassandra operator charts Signed-off-by: sebastien allamand <sebastien.allamand@orange.com> * Add flag to install the CRD Signed-off-by: sebastien allamand <sebastien.allamand@orange.com> Signed-off-by: Andrii Nasinnyk <anasinnyk@macpaw.com>
Signed-off-by: sebastien allamand sebastien.allamand@orange.com
What this PR does / why we need it:
This PR adds a new chart for cassandra-k8s-operator a Cassandra Kubernetes operator (CassKop).
This will ease the management of Cassandra cluster in Kubernetes.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]
)