Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/cassandra-k8s-operator] Add charts for the Orange's Cassandra Kubernetes operator #14414

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Conversation

allamand
Copy link
Contributor

@allamand allamand commented Jun 3, 2019

Signed-off-by: sebastien allamand sebastien.allamand@orange.com

What this PR does / why we need it:

This PR adds a new chart for cassandra-k8s-operator a Cassandra Kubernetes operator (CassKop).

This will ease the management of Cassandra cluster in Kubernetes.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @allamand. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maorfr
Copy link
Member

maorfr commented Jun 3, 2019

hey @allamand,

Have you considered hosting this chart and adding it to helm hub?
https://github.com/helm/hub/blob/master/Repositories.md

@allamand
Copy link
Contributor Author

allamand commented Jun 3, 2019

Hello @maorfr, actually I have nowhere to store the chart, so I thought it was better to add it in the helm/charts repository.

@allamand
Copy link
Contributor Author

allamand commented Jun 3, 2019

@maorfr, can we run e2e tests on this, is it ok for you ?

@maorfr
Copy link
Member

maorfr commented Jun 3, 2019

/ok-to-test

sure, i'll let the tests run
but regarding self hosting - you can use github pages:
https://github.com/helm/hub/blob/master/docs/github.md

wdyt?

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2019
@allamand
Copy link
Contributor Author

allamand commented Jun 3, 2019

I can take a look at github page, but I already use github pages for documentation sharing in the project. It seems to be at this time that it would be more useful in the charts repository but I'm open mind :)

Regarding the tests, they are failing because the CRD is missing when testing the chart.

In fact, I don't create the CRD in the helm willingly to avoid garbage collector of the CRD when deleting the chart. Any suggestion on how I should be doing that?

thanks for help

@obeyler
Copy link
Contributor

obeyler commented Jun 6, 2019

/approve

Signed-off-by: sebastien allamand <sebastien.allamand@orange.com>
@allamand
Copy link
Contributor Author

allamand commented Jun 6, 2019

/retest

Signed-off-by: sebastien allamand <sebastien.allamand@orange.com>
@allamand
Copy link
Contributor Author

allamand commented Jun 6, 2019

@maorfr I think It's Ready to merge. I would like to merge it in incubator/charts, and I will work in future to have the charts on our own repo.

Is that ok for you ?

@k8s-ci-robot
Copy link
Contributor

@obeyler: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@allamand
Copy link
Contributor Author

allamand commented Jun 6, 2019

/assign @jlegrone

@allamand
Copy link
Contributor Author

allamand commented Jun 6, 2019

/assign @prydonius

@prydonius
Copy link
Member

I would like to merge it in incubator/charts, and I will work in future to have the charts on our own repo.

I think that's fine for now. Just bear in mind that in the future we want to move towards a more distributed model, so folks will run their own chart repositories and add them to the Helm Hub (https://hub.helm.sh).

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: allamand, obeyler, prydonius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit b22db9e into helm:master Jun 7, 2019
@allamand allamand deleted the casskop branch June 11, 2019 13:03
anasinnyk pushed a commit to MacPaw/charts that referenced this pull request Jun 29, 2019
…dra Kubernetes operator (helm#14414)

* Add Cassandra operator charts

Signed-off-by: sebastien allamand <sebastien.allamand@orange.com>

* Add flag to install the CRD

Signed-off-by: sebastien allamand <sebastien.allamand@orange.com>
Signed-off-by: Andrii Nasinnyk <anasinnyk@macpaw.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants