This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/prometheus-operator] Lower dependency req #16523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
approved
|
/assign @anothertobi |
Signed-off-by: vas <vasily.sliouniaev@jet.com>
Signed-off-by: vas <vasily.sliouniaev@jet.com>
vsliouniaev
force-pushed
the
lower-dep
branch
from
1348081
to
0931d51
Compare
helm-bot
removed
the
Contribution Allowed
vsliouniaev
force-pushed
the
lower-dep
branch
from
0931d51
to
5b81ede
Compare
helm-bot
added
the
Contribution Allowed
Signed-off-by: vas <vasily.sliouniaev@jet.com>
Signed-off-by: vas <vasily.sliouniaev@jet.com>
vsliouniaev
force-pushed
the
lower-dep
branch
from
5b81ede
to
17db781
Compare
Signed-off-by: vas <vasily.sliouniaev@jet.com>
Signed-off-by: vas <vasily.sliouniaev@jet.com>
helm-bot
added
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gianrubio, vsliouniaev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
svrc
pushed a commit
to svrc/charts
that referenced
this pull request
Sep 4, 2019
* Lower dependency Signed-off-by: vas <vasily.sliouniaev@jet.com> * Resync rules and dashboards Signed-off-by: vas <vasily.sliouniaev@jet.com> * Bump version Signed-off-by: vas <vasily.sliouniaev@jet.com> * Remove anothertobi Signed-off-by: vas <vasily.sliouniaev@jet.com> * Fix cleanup flag Signed-off-by: vas <vasily.sliouniaev@jet.com> * Re-run sync Signed-off-by: vas <vasily.sliouniaev@jet.com> Signed-off-by: Harsha Katepal <hkatepal@ford.com>
svrc
pushed a commit
to svrc/charts
that referenced
this pull request
Sep 4, 2019
* Lower dependency Signed-off-by: vas <vasily.sliouniaev@jet.com> * Resync rules and dashboards Signed-off-by: vas <vasily.sliouniaev@jet.com> * Bump version Signed-off-by: vas <vasily.sliouniaev@jet.com> * Remove anothertobi Signed-off-by: vas <vasily.sliouniaev@jet.com> * Fix cleanup flag Signed-off-by: vas <vasily.sliouniaev@jet.com> * Re-run sync Signed-off-by: vas <vasily.sliouniaev@jet.com>
kengou
pushed a commit
to kengou/charts
that referenced
this pull request
Sep 18, 2019
* Lower dependency Signed-off-by: vas <vasily.sliouniaev@jet.com> * Resync rules and dashboards Signed-off-by: vas <vasily.sliouniaev@jet.com> * Bump version Signed-off-by: vas <vasily.sliouniaev@jet.com> * Remove anothertobi Signed-off-by: vas <vasily.sliouniaev@jet.com> * Fix cleanup flag Signed-off-by: vas <vasily.sliouniaev@jet.com> * Re-run sync Signed-off-by: vas <vasily.sliouniaev@jet.com>
ramkumarvs
pushed a commit
to yugabyte/charts-helm-fork
that referenced
this pull request
Sep 30, 2019
* Lower dependency Signed-off-by: vas <vasily.sliouniaev@jet.com> * Resync rules and dashboards Signed-off-by: vas <vasily.sliouniaev@jet.com> * Bump version Signed-off-by: vas <vasily.sliouniaev@jet.com> * Remove anothertobi Signed-off-by: vas <vasily.sliouniaev@jet.com> * Fix cleanup flag Signed-off-by: vas <vasily.sliouniaev@jet.com> * Re-run sync Signed-off-by: vas <vasily.sliouniaev@jet.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The feature to support both metrics and dashboards for Kubernetes < 1.14 and > 1.14 made the stated minimum requirement version (1.10) incompatible.
Simple fix + dashboards re-sync.
.Values.prometheusOperator.cleanupCustomResourceBeforeInstallto hopefully solve intermittent CI failuresWhich issue this PR fixes
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart])