Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/vault] Use fullname in case of release name is vault #16607

Merged
merged 1 commit into from
Aug 27, 2019
Merged

[incubator/vault] Use fullname in case of release name is vault #16607

merged 1 commit into from
Aug 27, 2019

Conversation

okgolove
Copy link
Collaborator

@okgolove okgolove commented Aug 26, 2019

Signed-off-by: Mikhail Naletov okgolove@markeloff.net

What this PR does / why we need it:

Use vault as fullname in case of release name is equal to chart name.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/chart])

Signed-off-by: Mikhail Naletov <okgolove@markeloff.net>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2019
@okgolove okgolove changed the title Use fullname in case of release name is vault [incubator/vault] Use fullname in case of release name is vault Aug 26, 2019
@okgolove
Copy link
Collaborator Author

/assign @jbialy

@jbialy
Copy link
Contributor

jbialy commented Aug 27, 2019

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. labels Aug 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbialy, okgolove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit a3932c0 into helm:master Aug 27, 2019
@okgolove okgolove deleted the feature/vault-naming branch August 27, 2019 13:30
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
Signed-off-by: Mikhail Naletov <okgolove@markeloff.net>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
Signed-off-by: Mikhail Naletov <okgolove@markeloff.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants