-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/grafana] Support ingress.extraPaths for grafana #16628
Conversation
Hi @paulopontesm. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8c35028
to
4f95e88
Compare
@paulopontesm: GitHub didn't allow me to assign the following users: rtluckie. Note that only helm members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4f95e88
to
cba8223
Compare
Signed-off-by: Paulo Martins <paulo.pontes.m@gmail.com>
cba8223
to
bec29aa
Compare
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulopontesm, zanhsieh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Paulo Martins <paulo.pontes.m@gmail.com>
Signed-off-by: Paulo Martins <paulo.pontes.m@gmail.com>
What this PR does / why we need it:
Adding ingress.extraPaths configuration to allow users to prepend additional paths to every host. This is required when working with aws-alb-ingress-controller and configuring ssl redirection (see https://kubernetes-sigs.github.io/aws-alb-ingress-controller/guide/tasks/ssl_redirect/).
Special notes for your reviewer:
Inspired on this PR (which was not closed yet): #15080
Checklist
[stable/chart]
)