Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] Support ingress.extraPaths for grafana #16628

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

paulopontesm
Copy link
Contributor

@paulopontesm paulopontesm commented Aug 27, 2019

What this PR does / why we need it:

Adding ingress.extraPaths configuration to allow users to prepend additional paths to every host. This is required when working with aws-alb-ingress-controller and configuring ssl redirection (see https://kubernetes-sigs.github.io/aws-alb-ingress-controller/guide/tasks/ssl_redirect/).

Special notes for your reviewer:

Inspired on this PR (which was not closed yet): #15080

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @paulopontesm. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 27, 2019
@paulopontesm paulopontesm force-pushed the grafana/extraPaths branch 2 times, most recently from 8c35028 to 4f95e88 Compare August 27, 2019 11:23
@k8s-ci-robot
Copy link
Contributor

@paulopontesm: GitHub didn't allow me to assign the following users: rtluckie.

Note that only helm members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @rtluckie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stable/grafana/Chart.yaml Outdated Show resolved Hide resolved
Signed-off-by: Paulo Martins <paulo.pontes.m@gmail.com>
@zanhsieh
Copy link
Collaborator

zanhsieh commented Sep 4, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulopontesm, zanhsieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1f03f9b into helm:master Sep 4, 2019
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
Signed-off-by: Paulo Martins <paulo.pontes.m@gmail.com>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
Signed-off-by: Paulo Martins <paulo.pontes.m@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants