[stable/metrics-server] bump metrics-server version

[pierluigilenoci]

What this PR does / why we need it:

Bump image version to latest at 0.3.3

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/chart])

[k8s-ci-robot]

Hi @PierluigiLenociAkelius. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierluigilenoci]

/assign @kennethaasan

[pierluigilenoci]

/assign @olemarkus

[pierluigilenoci]

I'm ready also to create a PR for whitespace formatting and to remove trailing blank lines as suggested by @bryantbiggs
https://github.com/PierluigiLenociAkelius/charts/commit/a8bbdcbf2d9b29ba049dd11a369453669429dd66

[olemarkus]

/lgtm

[pierluigilenoci]

@olemarkus as expected the build failed.

[olemarkus]

At least it seems given that it is the image version that is the problem. It is unclear to me why though. when I install/delete the chart from this PR it works just fine. So does linting the chart.

[pierluigilenoci]

@olemarkus Seems that this is not working. I create this one to fix a bit the chart #16685

[pierluigilenoci]

@bryantbiggs the metrics-server bump version don't work sadly.

[pierluigilenoci]

@olemarkus probably this is the reason: kubernetes-sigs/metrics-server#278 (comment)

If I use this options on k8s > v1.13 with kubelet (working without webhook authentication) works.

[olemarkus]

/ok-to-test

[olemarkus]

So the reason this is failing is that we have a test that looks like this:
wget -qO- https://<pod name>:443/version | grep -F <version, i.e 0.3.3>
And the version endpoint actually returns this:

{
  "major": "",
  "minor": "",
  "gitVersion": "v0.3.2-17+822102a6ca25b0-dirty",
  "gitCommit": "822102a6ca25b03318db397f1ceeec7b46f546a5",
  "gitTreeState": "dirty",
  "buildDate": "2019-05-02T18:40:38Z",
  "goVersion": "go1.10.8",
  "compiler": "gc",
  "platform": "linux/amd64"
}

This test in its current state is therefor completely useless and can be removed (or replaced by something more clever)

[pierluigilenoci]

The test could be improved but the answer is anyway wrong. So a fix is needed in both sides.

[pierluigilenoci]

There is a issue on metrics-server repo opened since june.
kubernetes-sigs/metrics-server#272

[pierluigilenoci]

@olemarkus the issue with the version is fixed, could you please approve again?

[olemarkus]

/lgtm

[pierluigilenoci]

@olemarkus sorry... I forgot to sign the commit :( my bad.

[olemarkus]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, PierluigiLenociAkelius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/metrics-server/OWNERS [olemarkus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierluigilenoci]

@olemarkus thank you! We finally did it! 🍾