Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometehus-blackbox-exporter] Improve configurability. #16815

Merged
merged 2 commits into from
Sep 5, 2019
Merged

[stable/prometehus-blackbox-exporter] Improve configurability. #16815

merged 2 commits into from
Sep 5, 2019

Conversation

josdotso
Copy link
Contributor

@josdotso josdotso commented Sep 3, 2019

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No

What this PR does / why we need it:

[stable/prometehus-blackbox-exporter] Improve configurability:

  • values.yaml:
    • Add: priorityClassName, podDisruptionBudget, strategy.
  • templates/deployment.yaml:
    • Parameterize: strategy.
    • Add: priorityClassName.
  • templates/poddisruptionbudget.yaml:
    • Add: new file.

Which issue this PR fixes

None

Special notes for your reviewer:

None

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 3, 2019
@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @josdotso. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 3, 2019
@josdotso
Copy link
Contributor Author

josdotso commented Sep 3, 2019

/assign @desaintmartin

@desaintmartin
Copy link
Collaborator

Thanks!
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2019
@josdotso
Copy link
Contributor Author

josdotso commented Sep 3, 2019

tide Pending — Not mergeable. Needs approved, lgtm labels.

Can you help with this @desaintmartin ? thanks

desaintmartin
desaintmartin suggested changes Sep 4, 2019
View reviewed changes
stable/prometheus-blackbox-exporter/templates/poddisruptionbudget.yaml Outdated
metadata:
name: {{ template "prometheus-blackbox-exporter.fullname" . }}
labels:
app: {{ template "prometheus-blackbox-exporter.name" . }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the new labels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is fixed in latest commit.

stable/prometheus-blackbox-exporter/templates/poddisruptionbudget.yaml Outdated
spec:
selector:
matchLabels:
app: {{ template "prometheus-blackbox-exporter.name" . }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is fixed in latest commit.

@josdotso
[stable/prometehus-blackbox-exporter] Improve configurability.
04bbfb9 
* values.yaml:
  * Add: priorityClassName, podDisruptionBudget, strategy.
* templates/deployment.yaml:
  * Parameterize: strategy.
  * Add: priorityClassName.
* templates/poddisruptionbudget.yaml:
  * Add: new file.

Signed-off-by: Joshua M. Dotson <josdotso@cisco.com>
@josdotso josdotso force-pushed the prometheus-blackbox-exporter.1 branch from edcd639 to 0cadba1 Compare September 5, 2019 02:09
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 5, 2019
@josdotso josdotso force-pushed the prometheus-blackbox-exporter.1 branch 2 times, most recently from 0cadba1 to 7a7d6cb Compare September 5, 2019 02:14
@josdotso
[prometheus-blackbox-exporter] Use new labels at templates/poddisrupt…
159c089 
…ionbudget.yaml

Signed-off-by: Joshua M. Dotson <josdotso@cisco.com>
@josdotso josdotso force-pushed the prometheus-blackbox-exporter.1 branch from 7a7d6cb to 159c089 Compare September 5, 2019 02:15
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 5, 2019
@josdotso
Copy link
Contributor Author

josdotso commented Sep 5, 2019

Sorry for the noise. Took a moment to get the sign-off right.

@desaintmartin
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desaintmartin, josdotso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 81365bb into helm:master Sep 5, 2019
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
@josdotso @kengou
[stable/prometehus-blackbox-exporter] Improve configurability. (helm#…
6d575a1 
…16815)

* [stable/prometehus-blackbox-exporter] Improve configurability.

* values.yaml:
  * Add: priorityClassName, podDisruptionBudget, strategy.
* templates/deployment.yaml:
  * Parameterize: strategy.
  * Add: priorityClassName.
* templates/poddisruptionbudget.yaml:
  * Add: new file.

Signed-off-by: Joshua M. Dotson <josdotso@cisco.com>

* [prometheus-blackbox-exporter] Use new labels at templates/poddisruptionbudget.yaml

Signed-off-by: Joshua M. Dotson <josdotso@cisco.com>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
@josdotso
[stable/prometehus-blackbox-exporter] Improve configurability. (helm#…
0c6a76a 
…16815)

* [stable/prometehus-blackbox-exporter] Improve configurability.

* values.yaml:
  * Add: priorityClassName, podDisruptionBudget, strategy.
* templates/deployment.yaml:
  * Parameterize: strategy.
  * Add: priorityClassName.
* templates/poddisruptionbudget.yaml:
  * Add: new file.

Signed-off-by: Joshua M. Dotson <josdotso@cisco.com>

* [prometheus-blackbox-exporter] Use new labels at templates/poddisruptionbudget.yaml

Signed-off-by: Joshua M. Dotson <josdotso@cisco.com>
@desaintmartin
Copy link
Collaborator

We miss a way to disable the PDB if not needed, let me do a PR.

@desaintmartin desaintmartin mentioned this pull request Oct 23, 2019
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desaintmartin desaintmartin desaintmartin requested changes

@gianrubio gianrubio Awaiting requested review from gianrubio

Assignees

@desaintmartin desaintmartin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josdotso @k8s-ci-robot @desaintmartin @helm-bot