Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] Fix README.md layout of table broken. #16828

Merged
merged 1 commit into from
Sep 4, 2019
Merged

[stable/grafana] Fix README.md layout of table broken. #16828

merged 1 commit into from
Sep 4, 2019

Conversation

zanhsieh
Copy link
Collaborator

@zanhsieh zanhsieh commented Sep 4, 2019 •
edited
Loading

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2019
@zanhsieh
Update README.md
424e3df 
Signed-off-by: zanhsieh <zanhsieh@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 4, 2019
@zanhsieh
Copy link
Collaborator Author

zanhsieh commented Sep 4, 2019

/ok-to-test

@zanhsieh
Copy link
Collaborator Author

zanhsieh commented Sep 4, 2019

/test pull-charts-e2e

@Eeemil
Copy link
Contributor

Eeemil commented Sep 4, 2019

Shouldn't this PR be named [stable/grafana]? :)

@zanhsieh
Copy link
Collaborator Author

zanhsieh commented Sep 4, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@zanhsieh: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zanhsieh zanhsieh changed the title Update README.md [stable/grafana] Update README.md Sep 4, 2019
@zanhsieh
Copy link
Collaborator Author

zanhsieh commented Sep 4, 2019

@Eeemil @maorfr
Could you approve this?

@zanhsieh zanhsieh changed the title [stable/grafana] Update README.md [stable/grafana] Fix README.md layout of table broken. Sep 4, 2019
@Eeemil
Copy link
Contributor

Eeemil commented Sep 4, 2019

/approve

@zanhsieh
Copy link
Collaborator Author

zanhsieh commented Sep 4, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@zanhsieh: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zanhsieh
Copy link
Collaborator Author

zanhsieh commented Sep 4, 2019

/assign Eeemil

@zanhsieh
Copy link
Collaborator Author

zanhsieh commented Sep 4, 2019

@Eeemil
Could you lgtm this?

@Eeemil
Copy link
Contributor

Eeemil commented Sep 4, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Eeemil: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Eeemil
Copy link
Contributor

Eeemil commented Sep 4, 2019

Sorry, I tried :(

@pierluigilenoci
Copy link
Contributor

/assign @maorfr

@maorfr
Copy link
Member

maorfr commented Sep 4, 2019

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Eeemil, maorfr, zanhsieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zanhsieh
Copy link
Collaborator Author

zanhsieh commented Sep 4, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 054b18d into helm:master Sep 4, 2019
@replicated-ship replicated-ship bot mentioned this pull request Sep 4, 2019
Open
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
@zanhsieh @kengou
Update README.md (helm#16828)
a8bd45d 
Signed-off-by: zanhsieh <zanhsieh@gmail.com>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
@zanhsieh
Update README.md (helm#16828)
d6827db 
Signed-off-by: zanhsieh <zanhsieh@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maorfr maorfr Awaiting requested review from maorfr

Assignees

@Eeemil Eeemil

@maorfr maorfr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/grafana] Layout of table in README.md is broken.
6 participants
@zanhsieh @Eeemil @k8s-ci-robot @pierluigilenoci @maorfr @helm-bot