Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-mongodb-exporter] Redeploy pods on config changes. #16835

Merged
merged 1 commit into from
Sep 4, 2019
Merged

[stable/prometheus-mongodb-exporter] Redeploy pods on config changes. #16835

merged 1 commit into from
Sep 4, 2019

Conversation

anas-aso
Copy link
Contributor

@anas-aso anas-aso commented Sep 4, 2019

Signed-off-by: Anas Ait Said Oubrahim anas.oubrahim@commercetools.de

Is this a new chart

No

What this PR does / why we need it:

Pods need to be redeployed when the config changes (secret.yaml in this case).

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/chart])

Signed-off-by: Anas Ait Said Oubrahim <anas.oubrahim@commercetools.de>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @anas-aso. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@steven-sheehy
Copy link
Collaborator

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2019
@steven-sheehy
Copy link
Collaborator

/test pull-charts-e2e

@steven-sheehy
Copy link
Collaborator

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anas-aso, steven-sheehy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit e8357d5 into helm:master Sep 4, 2019
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
Signed-off-by: Anas Ait Said Oubrahim <anas.oubrahim@commercetools.de>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
Signed-off-by: Anas Ait Said Oubrahim <anas.oubrahim@commercetools.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants