Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/vault] Custom backend #17448

Merged
merged 4 commits into from
Oct 2, 2019
Merged

[incubator/vault] Custom backend #17448

merged 4 commits into from
Oct 2, 2019

Conversation

zdevi
Copy link
Contributor

@zdevi zdevi commented Sep 26, 2019 •
edited
Loading

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

Stephane Etjemesian and others added 3 commits September 24, 2019 13:51
custom_backend
8c987ca 
Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>
@zdevi
Update Chart.yaml
07754ca 
Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>
@zdevi
Update values.yaml
b69273a 
Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 26, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @zdevi. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

update readme
66c2412 
Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 26, 2019
@zdevi
Copy link
Contributor Author

zdevi commented Sep 26, 2019

/assign @jbialy

@zdevi
Copy link
Contributor Author

zdevi commented Sep 26, 2019

/assign @prydonius

@jbialy
Copy link
Contributor

jbialy commented Oct 2, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2019
@jbialy
Copy link
Contributor

jbialy commented Oct 2, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbialy, zdevi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit be880e8 into helm:master Oct 2, 2019
isaaguilar pushed a commit to isaaguilar/charts that referenced this pull request Oct 3, 2019
@zdevi @isaaguilar
[incubator/vault] Custom backend (helm#17448)
799fdf9 
* custom_backend

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>

* Update Chart.yaml

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>

* Update values.yaml

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>

* update readme

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>
ali-sattari pushed a commit to ali-sattari/charts that referenced this pull request Oct 7, 2019
@zdevi @ali-sattari
[incubator/vault] Custom backend (helm#17448)
38af114 
* custom_backend

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>

* Update Chart.yaml

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>

* Update values.yaml

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>

* update readme

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>
Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
pennycoders pushed a commit to pennycoders/charts that referenced this pull request Oct 11, 2019
@zdevi @apica-ionos
[incubator/vault] Custom backend (helm#17448)
cbfd2a9 
* custom_backend

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>

* Update Chart.yaml

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>

* Update values.yaml

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>

* update readme

Signed-off-by: Stephane Etjemesian <setjemesian@synalabs.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbialy jbialy Awaiting requested review from jbialy

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@prydonius prydonius

@jbialy jbialy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zdevi @k8s-ci-robot @jbialy @prydonius @helm-bot