Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to 2048 game in README #322

Closed
wants to merge 1 commit into from

Conversation

gabrielecirulli
Copy link

Hey there!

I noticed that your repo links to 2048, but not to the official website created by me. Instead, it links to 2048game.com. While 2048game.com is a fork of the original 2048 and therefore also a version of 2048, play2048.co hosts the original version created by me, Gabriele Cirulli, in 2014. It will also receive improvements and updates soon.

I would love for you to consider this change!

Thanks,
Gabriele

Previously linked to 2048game.com. This site hosts the 2048 game but is not an official copy. Updated to play2048.co. This is an official version of the game made by the original creator, Gabriele Cirulli (originally hosted at https://gabrielecirulli.github.io/2048)
@mjswensen
Copy link
Collaborator

Hi Gabriele,

Thank you for bringing this to our attention! I would be happy to merge this change, but this repo is a collection of Progressive Web Apps, and play2048.co does not appear to provide a manifest.json, service workers, or other PWA features.

So here's what we'll do for now:

  1. I'll go ahead and remove the link to the unofficial fork now.
  2. If you add PWA support to play2048.co, please feel free to open another PR and we'll get it merged in.

Thanks!

@mjswensen mjswensen closed this Sep 10, 2024
mjswensen added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants