feat(domains): add multiple SNI endpoint support to domains:add
#1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check for multiple cert feature flag - Send cert if provided - Show picker if not provided
cafreeman
changed the title
domains:adddomains:add
brettgoulder
reviewed
Jan 7, 2020
| }) | ||
| .reply(422, { | ||
| id: 'invalid_params', | ||
| message: '\'sni_endpoint\' param is required when adding a domain to an app with multiple SSL certs.' |
There was a problem hiding this comment.
I think this is fine for now, but I do find an issue with sni_endpoint... I really wish we just call it --cert or something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07B0000007rFIYIA2/view
This PR adds multiple SNI endpoint support to
domains:addby doing the following things:allow-multiple-sni-endpointsfeature flag--certflag that allows users to specify a cert name when adding a domain to an app with multiple certs