Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undefined app name in dashboard command #2002

Merged
merged 4 commits into from
Feb 14, 2023
Merged

fix: undefined app name in dashboard command #2002

merged 4 commits into from
Feb 14, 2023

Conversation

subakva
Copy link
Contributor

@subakva subakva commented May 27, 2022

At some point, the return value containing the app name from favorites changed from app_name to resource_name, but this command was not updated. This PR fixes the reference.

@subakva subakva requested a review from a team as a code owner May 27, 2022 19:13
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:08 Inactive
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:08 Inactive
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:08 Inactive
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:08 Inactive
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:08 Inactive
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:08 Inactive
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:10 Inactive
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:10 Inactive
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:10 Inactive
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:10 Inactive
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:10 Inactive
@mimen mimen temporarily deployed to AcceptanceTests October 24, 2022 16:10 Inactive
@ryandagg ryandagg temporarily deployed to AcceptanceTests February 14, 2023 18:28 — with GitHub Actions Inactive
@ryandagg ryandagg temporarily deployed to AcceptanceTests February 14, 2023 18:28 — with GitHub Actions Inactive
@ryandagg ryandagg temporarily deployed to AcceptanceTests February 14, 2023 18:28 — with GitHub Actions Inactive
@ryandagg ryandagg temporarily deployed to AcceptanceTests February 14, 2023 18:28 — with GitHub Actions Inactive
@ryandagg ryandagg temporarily deployed to AcceptanceTests February 14, 2023 18:28 — with GitHub Actions Inactive
@ryandagg ryandagg temporarily deployed to AcceptanceTests February 14, 2023 18:28 — with GitHub Actions Inactive
ryandagg
ryandagg approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@ryandagg ryandagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparent introduction of bug: 335514b

Verified that this works locally and fixes an error in the latest cli release.

@ryandagg ryandagg merged commit 818ec34 into master Feb 14, 2023
@ryandagg ryandagg deleted the fix-dashboard-undefined-app branch February 14, 2023 18:55
This was referenced May 21, 2024
Open
Open
Open
This was referenced May 31, 2024
Open
Open
@AviyaNisanov AviyaNisanov mentioned this pull request Jun 12, 2024
Open
This was referenced Jul 17, 2024
Open
Open
@AviyaNisanov AviyaNisanov mentioned this pull request Jul 27, 2024
Open
This was referenced Aug 21, 2024
Open
Open
Open
This was referenced Aug 30, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandagg ryandagg ryandagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subakva @ryandagg @mimen