Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for viewing parallel test runs to CI plugin #980

Merged
merged 31 commits into from
Aug 14, 2018
Merged

Conversation

jabrown85
Copy link
Contributor

@jabrown85 jabrown85 commented Aug 13, 2018

Why

In order to better support parallel test runs going GA, we wanted to add a way to visually see the node statuses usingci:info and ci:last.

This means that the commands ci:info and ci:lastinclude now the --node flag.

  • Publish a changelog entry for this?

We also updated ci:run and ci:rerun to output the first node in parallel run cases for now.

Bonus points:

  • Migrated to oclif ci:info, ci:last, ci:run and ci:rerun
  • Added tests for command we previously had untested 🐼

What's next

  • Add support to visually show all test nodes executing when parallel test runs is enabled

What's next after next

  • Migrate to oclif

    • config-get
    • config-index
    • config-set
    • debug
    • index
    • open
  • Remove

    • migrate-manifest

Edited by @raulb

@jabrown85 jabrown85 requested review from a team August 13, 2018 19:46
Copy link
Contributor

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jabrown85 Thanks for helping me to bring it to the finish line! Since both of us worked on this PR, it'd might be helpful if we could get a review by the @heroku-cli team if possible!

In the meantime, I'll go ahead and approve 😎

@raulb raulb merged commit 052e0f1 into master Aug 14, 2018
@raulb raulb deleted the move-ci-to-oclif branch August 14, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants