-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for viewing parallel test runs to CI plugin #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulb
approved these changes
Aug 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jabrown85 Thanks for helping me to bring it to the finish line! Since both of us worked on this PR, it'd might be helpful if we could get a review by the @heroku-cli team if possible!
In the meantime, I'll go ahead and approve 😎
raulb
force-pushed
the
move-ci-to-oclif
branch
from
August 14, 2018 11:42
21c9a3d
to
81a7bda
Compare
- Update tsconfig - Move out utilities
raulb
force-pushed
the
move-ci-to-oclif
branch
from
August 14, 2018 11:43
81a7bda
to
6067b14
Compare
jdx
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In order to better support parallel test runs going GA, we wanted to add a way to visually see the node statuses using
ci:info
andci:last
.This means that the commands
ci:info
andci:last
include now the--node
flag.We also updated
ci:run
andci:rerun
to output the first node in parallel run cases for now.Bonus points:
ci:info
,ci:last
,ci:run
andci:rerun
What's next
What's next after next
Migrate to oclif
config-get
config-index
config-set
debug
index
open
Remove
migrate-manifest