Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go1.21, use for go1.21.0 #522

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Add go1.21, use for go1.21.0 #522

merged 5 commits into from
Aug 14, 2023

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Aug 14, 2023

This adds go1.21.0, and uses go1.21.0 for go1.21. It also adds a simple test for the go1.21 line.

Supersedes #521.

@joshwlewis joshwlewis requested a review from a team as a code owner August 14, 2023 16:34
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but CI is failing with curl: (6) Could not resolve host: null even on retry - an unrelated issue, but strange nonetheless?

@edmorley
Copy link
Member

edmorley commented Aug 14, 2023

Oh, it seemed unrelated because there were a dozen error lines (so it seemed multiple assets were failing the same way), but I guess the additional lines were just retries, so they were all from the newly added assets - whose URLs have just been fixed in the followup commits?

@joshwlewis
Copy link
Member Author

joshwlewis commented Aug 14, 2023

The change looks good, but CI is failing with curl: (6) Could not resolve host: null even on retry - an unrelated issue, but strange nonetheless?

I think this has to do with an upstream artifact naming change. Traditionally, the first release doesn't have a .0 suffix for go releases. For example, the first go1.20 was go1.20 (no .0), and go1.20.0 doesn't exist in the upstream distribution repository. For some reason, there is a suffix on this release - go1.21 doesn't exist upstream, but go1.21.0 does.

@joshwlewis
Copy link
Member Author

It looks like the .0 is intentional: golang/go#57631

@joshwlewis joshwlewis merged commit db40e51 into main Aug 14, 2023
4 checks passed
@joshwlewis joshwlewis deleted the go1.21 branch August 14, 2023 18:18
@joshwlewis joshwlewis mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants