Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node.js 17 and 18 support #1002

Merged
merged 34 commits into from
May 26, 2022
Merged

Add Node.js 17 and 18 support #1002

merged 34 commits into from
May 26, 2022

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented May 23, 2022

This PR is sort of an array of fixes related to improving support for Node.js 17 and 18.

Note that Node.js 17 is already retired and unsupported, but it's still possible for customers to use.

  • Adds the metrics plugin for Node.js 17 and 18.
  • Drops Node.js 12 metrics plugin updates.
  • Adds CI tests explicitly for Node.js 17 and 18.
  • Adjusts the range of Node.js versions that support metrics
  • Adjusts the range of Node.js versions we test against
  • Adds error messaging to help folks seeing failed builds due to the incompatibility of Node.js 18+ and heroku-18 (Node.js 18 wants libc6 2.28, which isn't available on heroku-18).
  • Fixes the broken test (was failing due to the Node.js 18+ and heroku-18 incompatibility)

GUS-W-11190190

@joshwlewis joshwlewis changed the title Add node-18 support Add Node.js 17 and 18 support May 23, 2022
Copy link
Contributor

@colincasey colincasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but it would nice to back this with a test. is it possible to have a test that runs only for a specific stack?

@joshwlewis joshwlewis marked this pull request as ready for review May 26, 2022 14:36
@joshwlewis joshwlewis requested a review from a team as a code owner May 26, 2022 14:36
@joshwlewis
Copy link
Member Author

👍 but it would nice to back this with a test. is it possible to have a test that runs only for a specific stack?

Yes, I agree. I was already working on it. The test proved that my original implementation wasn't working. I had to add some stderr redirection to get the node: /lib/x86_64-linux-gnu/libc.so.6: version 'GLIBC_2.28' not found (required by node) into the output log that we analyze.

CHANGELOG.md Outdated Show resolved Hide resolved
lib/failure.sh Outdated Show resolved Hide resolved
lib/binaries.sh Outdated Show resolved Hide resolved
lib/binaries.sh Outdated Show resolved Hide resolved
lib/binaries.sh Outdated Show resolved Hide resolved
spec/ci/node_16_metrics_spec.rb Outdated Show resolved Hide resolved
joshwlewis and others added 7 commits May 26, 2022 13:51
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@joshwlewis joshwlewis merged commit d53f03e into main May 26, 2022
@joshwlewis joshwlewis deleted the node-18 branch May 26, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants