Handle empty package name in mix hex.info #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it fails as follows:
$ mix hex.info ""
** (ArgumentError) the Access module supports only keyword lists (with atom keys), got: "meta"
If you want to search lists of tuples, use List.keyfind/3
(elixir 1.16.2) lib/access.ex:345: Access.get/3
(hex 2.0.6) lib/mix/tasks/hex.info.ex:108: Mix.Tasks.Hex.Info.print_package/2
This is because we call GET packages/ on hexpm which returns a list of objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it fails as follows:
This is because we call
GET packages/on hexpm which returns a list of objects, not an object.The second commit adds some guards on the API layer to calling the wrong URLs in the first place.
Note: While the
mix hex.info ""command might not make sense as user input, it might happen when scripting.