Skip to content

Commit

Permalink
Drop raises_regexp usage
Browse files Browse the repository at this point in the history
  • Loading branch information
asvetlov committed Dec 17, 2015
1 parent 1f0491e commit 66c4234
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 19 deletions.
1 change: 0 additions & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ pyenchant
sphinxcontrib-newsfeed
pytest
pytest-cov
pytest-raisesregexp
gunicorn
pygments
-e .
19 changes: 9 additions & 10 deletions tests/test_client_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,22 @@

import asyncio
import gc
import unittest
import unittest.mock

import inspect
import io
import re
import unittest
import unittest.mock
import urllib.parse
import os.path
import zlib

from http.cookies import SimpleCookie

import pytest

import aiohttp
from aiohttp.client_reqrep import ClientRequest, ClientResponse
from aiohttp.multidict import upstr, CIMultiDict, CIMultiDictProxy
from aiohttp import BaseConnector
from aiohttp.client_reqrep import ClientRequest, ClientResponse
from aiohttp.multidict import CIMultiDict, CIMultiDictProxy, upstr

import os.path


@pytest.yield_fixture
Expand Down Expand Up @@ -381,9 +380,9 @@ def test_query_str_param(make_request):

def test_query_bytes_param_raises(make_request):
for meth in ClientRequest.ALL_METHODS:
with pytest.raises_regexp(TypeError,
'not a valid non-string.*or mapping'):
with pytest.raises(TypeError) as ctx:
make_request(meth, 'http://python.org', params=b'test=foo')
assert re.match('not a valid non-string.*or mapping', str(ctx.value))


def test_query_str_param_is_not_encoded(make_request):
Expand Down
11 changes: 6 additions & 5 deletions tests/test_client_session.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import asyncio
import contextlib
import gc
import pytest
import re
import types
from unittest import mock

import aiohttp
import pytest
from aiohttp.client import ClientSession
from aiohttp.multidict import MultiDict, CIMultiDict
from aiohttp.connector import BaseConnector, TCPConnector
from aiohttp.multidict import CIMultiDict, MultiDict


@pytest.fixture
Expand Down Expand Up @@ -266,10 +267,10 @@ def test_connector_loop(loop):
stack.enter_context(contextlib.closing(another_loop))
connector = TCPConnector(loop=another_loop)
stack.enter_context(contextlib.closing(connector))
with pytest.raises_regexp(
ValueError,
"loop argument must agree with connector"):
with pytest.raises(ValueError) as ctx:
ClientSession(connector=connector, loop=loop)
assert re.match("loop argument must agree with connector",
str(ctx.value))


def test_cookies_are_readonly(session):
Expand Down
6 changes: 3 additions & 3 deletions tests/test_web_response.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,10 @@ def test_chunked_encoding_forbidden_for_http_10():
resp = StreamResponse()
resp.enable_chunked_encoding()

with pytest.raises_regexp(
RuntimeError,
"Using chunked encoding is forbidden for HTTP/1.0"):
with pytest.raises(RuntimeError) as ctx:
yield from resp.prepare(req)
assert re.match("Using chunked encoding is forbidden for HTTP/1.0",
str(ctx.value))


@pytest.mark.run_loop
Expand Down

0 comments on commit 66c4234

Please sign in to comment.