-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(stan) updated with improved coverage of language keywords and patterns. #1829
Conversation
- Almost complete rewrite. Corrected most patterns and updated function definitions. - Add "stanfuncs" as an alias
Thanks @jrnold! Would you by chance be willing to be the maintainer of Stan's syntax highlighting? If so, I can spin up a repository in the highlightjs organization. It would mean you could update the language independently of hljs core. |
@jrnold You still out there? Any thoughts about being maintainer for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a note in CHANGES.md?
This language is already in the core. Why should we move it away? |
Moving this to the language discussion. |
Since this is already in core though I was moving forward with reviewing it as if it was mergeable since it looks good to me... what to do long-term is a separate discussion. |
Bumping this from 9.15.11. |
@jrnold You still around? Would love to work on this with you and get it merged... |
@jrnold Ping. |
definitions.
This PR fixes the botched rebase in #1755.