Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement the initialization workflow #272

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Oct 19, 2023

Ⅰ. Describe what this PR did

Implement the initialization workflow for user to setup the admin account after installation, so no password needs to be specified or generated during installation.

Change details:

  1. Auto update the initialization status during start-up based on the current condition of having an admin user in the system, so user doesn't need to re-initialize the account after an update.
  2. Redirect to the login page after initialization.
  3. No longer present the way of getting the admin credential in the helm chart notes.
  4. Remove the random password generation support from helm chart.
  5. [Incompatible] Change the property of specifying admin password from admin.password.value to admin.password.

Screenshots:

image

image

Ⅱ. Does this pull request fix one issue?

fixes #232

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO marked this pull request as draft October 19, 2023 10:10
@CH3CHO CH3CHO marked this pull request as ready for review October 19, 2023 10:19
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@johnlanni johnlanni merged commit 9c3f849 into higress-group:main Oct 19, 2023
4 checks passed
@CH3CHO CH3CHO deleted the feat/init-workflow branch October 20, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

增加系统初始化配置流程
2 participants