Skip to content

Commit

Permalink
adds FIXME
Browse files Browse the repository at this point in the history
  • Loading branch information
jeremy-w committed Aug 14, 2013
1 parent 69c98ec commit c825033
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion BNRPersistence/BNRDataBuffer+Encryption.m
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,11 @@ - (void)encryptWithKey:(NSString *)key salt:(const BNRSalt *)salt

BNRSalt littleSalt = *salt;
BNRSaltToLittle(&littleSalt);


/* (jws/2013-08-14)FIXME: We should be using in-place cryption where
* possible, and taking advantage of being able to feed buffers one by one
* into the Update() function, rather than having to manually paste things
* together all the time. */
// Create a scratch buffer so we can prepend the 8 bytes of salt.
// We will look for these salt bytes when decrypting to confirm that we were successful.
int scratchBufferLength = 8 + length;
Expand Down

0 comments on commit c825033

Please sign in to comment.