Only show toolchain list once when using --installed

[marcospb19]

Fixes #86.

[marcospb19]

EDIT: see comment below from Joshua.

I force pushed the fix to a test, it was panicking in the main function.

One thing I noticed is that

cargo-sweep/src/main.rs

Line 157 in a36602f

))?;

is the only place where main can panic, in the other 9 places, the error is outputted and the program exits, maybe we should get rid of this one panic?

[jyn514]

I force pushed the fix to a test, it was panicking in the main function.

We cleared this up in DMs, this was a panic in the test suite, not cargo-sweep itself.

[jyn514]

Thanks! Left a couple nits but this looks good overall :) could you please add a test showing the new behavior?

[marcospb19]

I think I'll wait for #78 to merge, to avoid giving him new conflicts again, and to reuse the project structure he created to test -r to test this one right here.

[marcospb19]

Changing to draft while we wait on #78 to be merged to reuse some of the testing code.

[marcospb19]

I did this because it's simpler to run on tests/, the alternative here would probably be to copy all projects to a tempdir, create the target folder in each copy, and run sweep -r -i in this tempdir instead of tests/.

[marcospb19]

Excuse me @jyn514, could you please update the label S-waiting-on-author to S-waiting-on-review?

[jyn514]

Sorry for the long delay. I am taking a semi-permanent break from github and don't know when I'll have time to maintain cargo-sweep.

@marcospb19 you've done a lot of work on cargo-sweep in the past and I trust your judgement - are you interested in becoming a maintainer? :)

[jyn514]

In the meantime I'm happy to merge this as soon as you fix the conflicts.

[marcospb19]

@jyn514

Sorry for the long delay. I am taking a semi-permanent break from github and don't know when I'll have time to maintain cargo-sweep.

Have a great break! And thanks for everything you've done.

@marcospb19 you've done a lot of work on cargo-sweep in the past and I trust your judgement - are you interested in becoming a maintainer? :)

I feel flattered to have your trust!

Yeah, I'm down! I believe the next good step would be to check out cargo-clean-all, see if both overlap and where are they going with the project.

In the meantime I'm happy to merge this as soon as you fix the conflicts.

Ok, I'll do that!

[marcospb19]

Rebase done, conflicts solved.

[marcospb19]

Tests failing due to that bad regex on that specific test... let me see what I can do.

Update to self: in macOS, there's a additional .o file being removed.

[marcospb19]

Done by last commit! Clippy is failing due to a proc-macro2 update issue, which should be fixed by another PR.

[jyn514]

Yeah, I'm down! I believe the next good step would be to check out cargo-clean-all, see if both overlap and where are they going with the project.

sounds perfect! check your email, you should have an invite :)