Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work with Pandas 2.2 release candidate #6074

Merged
merged 11 commits into from
Jan 19, 2024
Merged

Update to work with Pandas 2.2 release candidate #6074

merged 11 commits into from
Jan 19, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 17, 2024

Also removes a warning emitted from xarray 2024.1

Still, one warning causing problem: Passing a SingleBlockManager to GeoSeries is deprecated and will raise in a future version. Use public APIs instead.. This is likely a problem that needs to be fixed in spatial pandas. Issue here: holoviz/spatialpandas#137

@hoxbro hoxbro marked this pull request as draft January 17, 2024 15:27
@hoxbro hoxbro added the type: compatibility Compability with upstream packages label Jan 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (10433e6) 88.64% compared to head (2f5827c) 88.65%.

Files Patch % Lines
holoviews/element/selection.py 80.95% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6074      +/-   ##
==========================================
+ Coverage   88.64%   88.65%   +0.01%     
==========================================
  Files         314      314              
  Lines       65794    65817      +23     
==========================================
+ Hits        58321    58348      +27     
+ Misses       7473     7469       -4     
Flag Coverage Δ
ui-tests 23.66% <37.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro
Copy link
Member Author

hoxbro commented Jan 19, 2024

I will merge this if tests pass, as this should work with the currently released pandas.

@hoxbro hoxbro changed the title [DO NOT MERGE] Test Pandas release candidate Update to work with Pandas release candidate Jan 19, 2024
@hoxbro hoxbro marked this pull request as ready for review January 19, 2024 11:12
@hoxbro hoxbro enabled auto-merge (squash) January 19, 2024 11:12
@hoxbro hoxbro changed the title Update to work with Pandas release candidate Update to work with Pandas 2.2 release candidate Jan 19, 2024
@hoxbro hoxbro disabled auto-merge January 19, 2024 11:12
@hoxbro hoxbro enabled auto-merge (squash) January 19, 2024 11:12
@hoxbro hoxbro merged commit dbab2b7 into main Jan 19, 2024
12 checks passed
@hoxbro hoxbro deleted the pandas22 branch January 19, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: compatibility Compability with upstream packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants