This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
Add discovery of HEOS devices #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2019
Kane610
reviewed
Apr 2, 2019
|
|
||
| def get_entries(self): | ||
| """Get all the HEOS devices.""" | ||
| return self.find_by_st("urn:schemas-denon-com:device:ACT-Denon:1") |
There was a problem hiding this comment.
This won't identify receivers or other denon devices?
There was a problem hiding this comment.
According to the CLI Specification (page 6), this is the search target for HEOS-enabled devices. It will include Denon and Marantz receivers, amps, and speakers that have HEOS, which is intentional. It should not match older devices that aren't HEOS enabled.
There was a problem hiding this comment.
That could possibly be clarified.
Kane610
approved these changes
Apr 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add discovery of HEOS devices.
Pull request in home-assistant: home-assistant/core#22652