Skip to content
This repository has been archived by the owner on Oct 1, 2021. It is now read-only.

Add the ability to suppress mdns service scans for some services #256

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 22, 2021

  • When we are already running a ServiceBrowser for services that netdisco scans for
    we will already have all the answers we expect to get in the cache. By scanning
    for these services again, we generate additional network traffic. Since the
    known answer list was not shared between ServiceBrowsers in earlier versions
    of zeroconf, we will send an empty list which will cause every services we
    already have in the cache to be re-populated.

@bdraco
Copy link
Member Author

bdraco commented Jun 22, 2021

netdisco/discoverables/apple_tv.py:        super(Discoverable, self).__init__(nd, '_appletv-v2._tcp.local.')
netdisco/discoverables/arduino.py:        super(Discoverable, self).__init__(nd, '_arduino._tcp.local.')
netdisco/discoverables/axis.py:        super(Discoverable, self).__init__(nd, '_axis-video._tcp.local.')
netdisco/discoverables/bluesound.py:        super(Discoverable, self).__init__(nd, '_musc._tcp.local.')
netdisco/discoverables/bose_soundtouch.py:        super(Discoverable, self).__init__(nd, '_soundtouch._tcp.local.')
netdisco/discoverables/digitalstrom.py:        super(Discoverable, self).__init__(nd, '_http._tcp.local.')
netdisco/discoverables/enigma2.py:        super(Discoverable, self).__init__(nd, '_e2stream._tcp.local.')
netdisco/discoverables/esphome.py:        super().__init__(nd, '_esphomelib._tcp.local.')
netdisco/discoverables/freebox.py:        super(Discoverable, self).__init__(nd, '_fbx-api._tcp.local.')
netdisco/discoverables/google_cast.py:        super(Discoverable, self).__init__(nd, '_googlecast._tcp.local.')
netdisco/discoverables/hass_ios.py:        super(Discoverable, self).__init__(nd, '_hass-ios._tcp.local.')
netdisco/discoverables/hass_mobile_app.py:        super(Discoverable, self).__init__(nd, '_hass-mobile-app._tcp.local.')
netdisco/discoverables/hikvision.py:        super(Discoverable, self).__init__(nd, '_http._tcp.local.')
netdisco/discoverables/home_assistant.py:        super(Discoverable, self).__init__(nd, '_home-assistant._tcp.local.')
netdisco/discoverables/homekit.py:        super(Discoverable, self).__init__(nd, '_hap._tcp.local.')
netdisco/discoverables/homekit.py:        name = name.replace('._hap._tcp.local.', '')
netdisco/discoverables/hp_printer.py:        super(Discoverable, self).__init__(nd, '_printer._tcp.local.')
netdisco/discoverables/kodi.py:        super(Discoverable, self).__init__(nd, '_http._tcp.local.')
netdisco/discoverables/lg_smart_device.py:        super(Discoverable, self).__init__(nd, '_lg-smart-device._tcp.local.')
netdisco/discoverables/lutron.py:        super(Discoverable, self).__init__(nd, '_lutron._tcp.local.')
netdisco/discoverables/nanoleaf_aurora.py:        super(Discoverable, self).__init__(nd, '_nanoleafapi._tcp.local.')
netdisco/discoverables/sabnzbd.py:        super(Discoverable, self).__init__(nd, '_http._tcp.local.')
netdisco/discoverables/spotify_connect.py:        super(Discoverable, self).__init__(nd, '_spotify-connect._tcp.local.')
netdisco/discoverables/tivo_dvr.py:        super(Discoverable, self).__init__(nd, '_tivo-remote._tcp.local.')
netdisco/discoverables/volumio.py:        super(Discoverable, self).__init__(nd, '_Volumio._tcp.local.')

All the types

- When we are already running a ServiceBrowser for services that netdisco scans for
  we will already have all the answers we expect to get in the cache. By scanning
  for these services again, we generate additional network traffic. Since the
  known answer list was not shared between ServiceBrowsers in earlier versions
  of zeroconf, we will send an empty list which will cause every services we
  already have in the cache to be re-populated.
@bdraco bdraco marked this pull request as ready for review June 22, 2021 20:25
@balloob balloob merged commit 8212b4e into home-assistant-libs:master Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants