Respect icloud Enable polling updates
#117984
Conversation
home-assistant
bot
added
cla-signed
integration: icloud
new-feature
small-pr
|
Hey there @Quentame, @nzapponi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
fopina
changed the title
Enable polling updatesEnable polling updates
…ions` and do not poll devices/location if disabled
fopina
force-pushed
the
icloud/disable_polling
branch
from
4ad1299
to
5112f2c
Compare
MartinHjelmare
changed the title
Enable polling updatesEnable polling updates
| @@ -161,6 +161,7 @@ def update_devices(self) -> None: | |||
| """Update iCloud devices.""" | |||
| if self.api is None: | |||
| return | |||
| _LOGGER.debug("Updating devices") | |||
There was a problem hiding this comment.
If this is going into debug logging, could you please make the debug message a bit more expressive? Especially, if this will cause the "Someone logged in..." emails (which we all loathe).
There was a problem hiding this comment.
This message is related to updating devices.
If it kicks in a re-authentication (due to expired token), it will send that email, but i don't think this is the place to log that...
I think "Updating devices" is quite clear for when devices are being updated 😃
This is mostly to make sure that polling is not happening (ie: this message does not show up in logs)
There was a problem hiding this comment.
But maybe it would be nice to have that message (logging in) to match the emails, though debug logging is disabled after some time, in integrations, so it probably needed INFO level.
I'll let one of the owners comment on that before using this PR for that
|
If this in fact solves the email issue, then please make sure to follow up with that issue when merged. :-) |
Proposed change
Make icloud integration to respect
Enable polling updatesunderSystem Optionsby not polling device details (if disabled).My personal motivation being:
I don't want to drain device battery to get their locations, I only want to use the "Play Sound" feature when I don't know where the phone is.
Disabling polling also prevents the daily email of "someone has logged in your account" from Apple 😄
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: