Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya pool heating pumps #118415

Merged
merged 12 commits into from
Jun 22, 2024
Merged

Add Tuya pool heating pumps #118415

merged 12 commits into from
Jun 22, 2024

Conversation

cRemE-fReSh
Copy link
Contributor

@cRemE-fReSh cRemE-fReSh commented May 29, 2024

Proposed change

I would like to add support for Pool Heating Pumps, e.g. Poolsana InverNext (https://www.poolsana.de/pool-full-inverter-waermepumpe-poolsana-inverpower-next-15)
Category "znrb", product id "abb8kaxcphfzkwsg". Unfortunately this category seems not to be documented in the tuya dev docs.
Find below the referring Diagnostic file that discribes the component.
tuya-397980156da2e8092eebaee422fa13ec-Wärmepumpe Pool-bf5e6aa83af148249728aae59317f22c(2).json
Remark: I have left out "work_state" because this seems to be a dead status that never chances independent from the state of the heat pump. Same as "mode" from issue #118265 because this does not exist in mine.
It is an "mimimum" integration that allows to get the current temperature, set the set temperature and switch the entity on and off. Same as getting the three values from the entity.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@cRemE-fReSh cRemE-fReSh requested a review from frenck as a code owner May 29, 2024 19:16
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cRemE-fReSh

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft May 29, 2024 19:16
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @tuya, @zlinoliver, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cRemE-fReSh cRemE-fReSh marked this pull request as ready for review May 29, 2024 19:18
@MartinHjelmare MartinHjelmare changed the title Tuya: Add support for pool heating pumps Add Tuya pool heating pumps May 30, 2024
@Cyrelion

This comment was marked as off-topic.

@superior82
Copy link

I have also the same pool heat pump. If there is anything I can do, please let me know. :)

@gum073

This comment was marked as off-topic.

@Cyrelion

This comment was marked as off-topic.

@JanKraslice

This comment was marked as off-topic.

@Cyrelion

This comment was marked as off-topic.

Support for znrb added
Support for znrb added
Support for znrb added
Remove Manufacturer
Remove Manufacturer
Remove Manufacturer
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cRemE-fReSh 👍

../Frenck

@frenck frenck merged commit f8c1710 into home-assistant:dev Jun 22, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuya Pool heat pump (unsupported)
6 participants