Xiaomi aqara gateway alarm control #20294

toribola · 2019-01-21T15:47:09Z

Description:

Arm/Disarm xiaomi aqara alarm

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for `configuration.yaml` (if applicable):

xiaomi_aqara:
  gateways:
    - mac: AA:BB:CC:DD:EE:FF
      key: 123456abcde
      token: 11223344556677889900aabbccddeeff 
alarm_control_panel:
    - platform: xiaomi_gateway
      host: 10.0.0.1
      token: 11223344556677889900aabbccddeeff

Checklist:

[X ] The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

homeassistant · 2019-01-21T15:47:11Z

Hi @toribola,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant/components/alarm_control_panel/xiaomi_gateway.py

frenck · 2019-01-21T18:57:31Z

⚠️ I was unable to find a documentation PR (matching this code change) in our documentation repository.

📚Please, update the documentation and open a PR for it (be sure to create a documentation PR against the next branch) and link 🔗 this PR and the new documentation PR by mentioning the link to the PR's in both openings posts/descriptions.

🏷 I am adding the docs-missing label until this has been resolved.

👍 Thanks (times a million!)

rytilahti

Preliminary review, in order to get this merged the protocol-specific parts need to be moved into the upstream lib (see rytilahti/python-miio#470) and all references to xiaomi_aqara need to be removed.

rytilahti · 2019-01-30T17:50:39Z

homeassistant/components/alarm_control_panel/xiaomi_gateway.py

+from homeassistant.components.alarm_control_panel import AlarmControlPanel
+import homeassistant.helpers.config_validation as cv
+from homeassistant.components.switch import (PLATFORM_SCHEMA, )
+from homeassistant.components.xiaomi_aqara import (CONF_HOST, CONF_TOKEN, )


Import CONF_HOST and CONF_TOKEN from homeassistant.const instead of from xiaomi_aqara.

rytilahti · 2019-01-30T17:50:58Z

homeassistant/components/alarm_control_panel/xiaomi_gateway.py

+_LOGGER = logging.getLogger(__name__)
+
+DEFAULT_NAME = 'Xiaomi Gateway Alarm'
+DATA_KEY = 'alarm_control_panel.xiaomi_gateway'


alarm_control_panel.xiaomi_miio.

rytilahti · 2019-01-30T17:51:22Z

homeassistant/components/alarm_control_panel/xiaomi_gateway.py

+    vol.Required(CONF_HOST): cv.string,
+    vol.Required(CONF_TOKEN): vol.All(cv.string, vol.Length(min=32, max=32)),
+    vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string,
+    vol.Optional(CONF_TURN_ON_COMMAND, default='set_arming'): cv.string,


Is there some specific reason to make this and turn_off configurable?

rytilahti · 2019-01-30T17:51:59Z

homeassistant/components/alarm_control_panel/xiaomi_gateway.py

+        vol.All(cv.ensure_list, [cv.string]),
+})
+
+REQUIREMENTS = ['python-miio>=0.3.7']


Needs to be pinned on exact version, i.e. ==0.3.7.

rytilahti · 2019-01-30T18:19:48Z

homeassistant/components/alarm_control_panel/xiaomi_gateway.py

+        """Turn on."""
+        result = await self._try_command(
+            "Turning the miio device on failed.", self._device.send,
+            'set_arming', ['on'])


This needs to be implemented in the backend lib, I just pushed my old code online if you are interested in working on it: rytilahti/python-miio#470

rytilahti · 2019-01-30T18:20:01Z

homeassistant/components/alarm_control_panel/xiaomi_gateway.py

+        """Turn off."""
+        result = await self._try_command(
+            "Turning the miio device off failed.", self._device.send,
+            'set_arming', ['off'])


Same as above, this needs to be done in the upstream library.

rytilahti · 2019-01-30T18:20:25Z

homeassistant/components/alarm_control_panel/xiaomi_gateway.py

+
+        print(result)
+        if result:
+            pass


Remove debug prints, do proper error handling if necessary.

rytilahti · 2019-01-30T18:20:32Z

homeassistant/components/alarm_control_panel/xiaomi_gateway.py

+            'set_arming', ['off'])
+        print(result)
+        if result:
+            pass


Same as above.

rytilahti · 2019-01-30T18:20:58Z

homeassistant/components/alarm_control_panel/xiaomi_gateway.py

+        try:
+            state = await self.hass.async_add_job(
+                self._device.send, 'get_arming', [self._state_property])
+            state = state.pop()


Needs to be done in the upstream library.

rytilahti · 2019-01-30T18:21:44Z

homeassistant/components/xiaomi_aqara.py

@@ -285,6 +287,9 @@ def push_data(self, data, raw_data):
        _LOGGER.debug("PUSH >> %s: %s", self, data)
        was_unavailable = self._async_track_unavailable()
        is_data = self.parse_data(data, raw_data)
+        print("=========================================================")
+        print(raw_data)
+        print("=========================================================")


Remove all modifications and references to xiaomi_aqara. xiaomi_aqara implements the developer api access, xiaomi_miio is the correct one for this.

balloob · 2019-02-26T23:10:58Z

This PR seems to have gone stale. Closing it.

toribola and others added 2 commits January 15, 2019 18:39

First add of xiaomi gateway alarm

ffb021b

XiaomiAqaraAlarm

dcc8689

toribola requested review from Danielhiversen and syssi as code owners January 21, 2019 15:47

homeassistant added integration: xiaomi_aqara new-platform platform: alarm_control_panel.xiaomi_gateway labels Jan 21, 2019

homeassistant added the cla-needed label Jan 21, 2019

ghost added in progress and removed cla-needed integration: xiaomi_aqara new-platform platform: alarm_control_panel.xiaomi_gateway labels Jan 21, 2019

houndci-bot reviewed Jan 21, 2019

View reviewed changes

homeassistant/components/alarm_control_panel/xiaomi_gateway.py Outdated Show resolved Hide resolved

homeassistant added the cla-signed label Jan 21, 2019

XiaomiAqaraAlarm

b35ef66

frenck added the docs-missing label Jan 21, 2019

Fix for travis

8cb83cf

rytilahti mentioned this pull request Jan 30, 2019

Initial support for xiaomi gateway devices rytilahti/python-miio#470

Merged

rytilahti requested changes Jan 30, 2019

View reviewed changes

balloob closed this Feb 26, 2019

ghost removed the in progress label Feb 26, 2019

starkillerOG mentioned this pull request Feb 2, 2020

Add support for Xiaomi gateway alarm? Danielhiversen/PyXiaomiGateway#166

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Xiaomi aqara gateway alarm control #20294

Xiaomi aqara gateway alarm control #20294

toribola commented Jan 21, 2019 •

edited

Loading

homeassistant commented Jan 21, 2019

frenck commented Jan 21, 2019

rytilahti left a comment

rytilahti Jan 30, 2019

rytilahti Jan 30, 2019

rytilahti Jan 30, 2019

rytilahti Jan 30, 2019

rytilahti Jan 30, 2019

rytilahti Jan 30, 2019

rytilahti Jan 30, 2019

rytilahti Jan 30, 2019

rytilahti Jan 30, 2019

rytilahti Jan 30, 2019

balloob commented Feb 26, 2019

Xiaomi aqara gateway alarm control #20294

Xiaomi aqara gateway alarm control #20294

Conversation

toribola commented Jan 21, 2019 • edited Loading

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

homeassistant commented Jan 21, 2019

frenck commented Jan 21, 2019

rytilahti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

balloob commented Feb 26, 2019

toribola commented Jan 21, 2019 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):