Exit when command_classes are missing thermostat Zwave #2824
Conversation
turbokongen
force-pushed
the
zwave_fixes
branch
from
5fa1dc3
to
80d4ac4
Compare
| @@ -52,6 +52,10 @@ def setup_platform(hass, config, add_devices, discovery_info=None): | |||
| _LOGGER.debug("Remotec ZXT-120 Zwave Thermostat, ignoring") | |||
| return | |||
|
|
|||
| if value.command_class != COMMAND_CLASS_SENSOR_MULTILEVEL and \ | |||
| value.command_class != COMMAND_CLASS_THERMOSTAT_SETPOINT: | |||
| return | |||
There was a problem hiding this comment.
Wait, now you're checking if 1 value is equal to 2 different values. I'm assuming those 2 values are not the same so this test will always be false.
There was a problem hiding this comment.
No, This is inverted logic. We use the same here:
https://github.com/turbokongen/home-assistant/blob/zwave_fixes/homeassistant/components/garage_door/zwave.py#L28
Or maybe this is or we need? 😕
I see. We need to test each individual not together.
There was a problem hiding this comment.
I see I need to figure out a different method to do this. Because we pass in only one command_class to begin with.
turbokongen
force-pushed
the
zwave_fixes
branch
3 times, most recently
from
40e90fa
to
bbb125d
Compare
| @@ -51,6 +51,11 @@ def setup_platform(hass, config, add_devices, discovery_info=None): | |||
| if DEVICE_MAPPINGS[specific_sensor_key] == WORKAROUND_IGNORE: | |||
| _LOGGER.debug("Remotec ZXT-120 Zwave Thermostat, ignoring") | |||
| return | |||
| if not (value.node.get_values_for_command_class( | |||
There was a problem hiding this comment.
An empty dict is already falsey while a dict with any info in it is true. So no need to call items() on it.
› python3
Python 3.4.3 (default, Aug 11 2015, 08:57:25)
[GCC 4.2.1 Compatible Apple LLVM 6.1.0 (clang-602.0.53)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> bool({})
False
>>> bool({'hello': 1})
True
turbokongen
force-pushed
the
zwave_fixes
branch
from
bbb125d
to
525598e
Compare
Description:
Make sure essential values are present. Exit if not.
#2820