Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check config script: various fixes #2967

Merged
merged 2 commits into from
Aug 25, 2016
Merged

Check config script: various fixes #2967

merged 2 commits into from
Aug 25, 2016

Conversation

kellerza
Copy link
Member

Description:
Various fixes to the check_config script:

  • --secrets Secrets never cached
  • --files patching files at config_util
  • --info all was broken

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Teagan42
Teagan42 reviewed Aug 25, 2016
View reviewed changes
homeassistant/util/yaml.py
except FileNotFoundError:
secrets = {}
return {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded return

@Teagan42 Teagan42 merged commit 17631cd into home-assistant:dev Aug 25, 2016
@kellerza kellerza deleted the checksecrets branch August 25, 2016 05:51
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellerza @Teagan42