Sorted yaml output for check_config #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellerza
force-pushed
the
check_config
branch
from
6aa0897
to
803e4f7
Compare
|
LGTM 🐬 |
|
Wouldn't it be nicer if all errors are ordered to the same order as they occur in the config? To achieve that, replace these lines to assign |
kellerza
force-pushed
the
check_config
branch
from
803e4f7
to
793dadd
Compare
balloob
reviewed
Sep 15, 2016
| @@ -105,26 +106,26 @@ def run(script_args: List) -> int: | |||
|
|
|||
| if len(res['except']) > 0: | |||
| print(color('bold_white', 'Failed config')) | |||
| for domain, config in res['except'].items(): | |||
| for domain, config in sorted(res['except'].items()): | |||
There was a problem hiding this comment.
By using sorted you're overriding the order of the items in the config, is this on purpose?
There was a problem hiding this comment.
Overlooked the impact of your OrderedDict suggestion. Fixed
| print(color('reset')) | ||
|
|
||
| if domain_info: | ||
| if 'all' in domain_info: | ||
| print(color('bold_white', 'Successful config (all)')) | ||
| for domain, config in res['components'].items(): | ||
| for domain, config in sorted(res['components'].items()): |
kellerza
force-pushed
the
check_config
branch
from
793dadd
to
a11509a
Compare
kellerza
force-pushed
the
check_config
branch
from
a11509a
to
ec59804
Compare
|
Looks good! 🐬 |
tylerstraub
referenced
this pull request
Sep 23, 2016
* Use voluptuous for input slider * floats * _setup_component * Imperative mood * CONFIG_SCHEMA * None returns empty ensure_list * allow_extra * bool * restore ensure_list behaviour
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Sort the yaml output of check_config to have a more consistent display
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass