Increase allowable zwave polling intensity values #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mezz64, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @turbokongen and @balloob to be potential reviewers. |
|
Nice catch. I myself don't use polling. 👍 |
hartmms
pushed a commit
to hartmms/home-assistant
that referenced
this pull request
Oct 5, 2016
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Recent voluptuous migration for the zwave component limited the polling intensity values to (0, 1, 2), but openzwave will act on any multiple and doesn't actually have a limit. (See [http://www.openzwave.com/dev/classOpenZWave_1_1Manager.html#ab62582b7bcfec34574fb2aa7c54d147f])
This increases the allowable values up to 5, which is the max I use in my setup, but we may be better off just restricting it to int rather than a specific range.
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass