Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wemo 'Socket' model for Homekit discovery #38765

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

esev
Copy link
Contributor

@esev esev commented Aug 11, 2020

Proposed change

The model WSP080 WiFi Smart Plug responds to Homekit discovery messages with Socket as the model.
https://www.belkin.com/us/p/P-WSP080/

[homeassistant.components.zeroconf] Discovered new device Wemo Plug 603._hap._tcp.local. {'host': '192.168.1.5', 'port': 54664, 'hostname': 'Wemo Plug 603.local.', 'type': '_hap._tcp.local.', 'name': 'Wemo Plug 603._hap._tcp.local.', 'properties': {'_raw': {'c#': b'2', 'ff': b'2', 'id': b'63:30:B3:10:00:01', 'md': b'Socket', 'pv': b'1.1', 's#': b'1', 'sf': b'1', 'ci': b'7', 'sh': b'AD4l7g=='}, 'c#': '2', 'ff': '2', 'id': '63:30:B3:10:00:01', 'md': 'Socket', 'pv': '1.1', 's#' : '1', 'sf': '1', 'ci': '7', 'sh': 'AD4l7g=='}}

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Corresponds with the model WSP080 WiFi Smart Plug
https://www.belkin.com/us/p/P-WSP080/

```
[homeassistant.components.zeroconf] Discovered new device Wemo Plug 603._hap._tcp.local. {'host': '10.234.200.95', 'port': 54664, 'hostname': 'Wemo Plug 603.local.', 'type': '_hap._tcp.local.', 'name': 'Wemo Plug 603._hap._tcp.local.', 'properties': {'_raw': {'c#': b'2', 'ff': b'2', 'id': b'63:30:B3:10:BA:B1', 'md': b'Socket', 'pv': b'1.1', 's#': b'1', 'sf': b'1', 'ci': b'7', 'sh': b'AD4l7g=='}, 'c#': '2', 'ff': '2', 'id': '63:30:B3:10:BA:B1', 'md': 'Socket', 'pv': '1.1', 's#' : '1', 'sf': '1', 'ci': '7', 'sh': 'AD4l7g=='}}
```
Copy link
Member

@cgarwood cgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bachya bachya merged commit f01634f into home-assistant:dev Aug 21, 2020
@esev esev deleted the wemo_homekit_socket branch August 4, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants