Restore somfy state in optimistic mode on restart #42426
Conversation
Set device class
|
I was planning to implement the assumed_state property for stateless devices (so the one targeted by this optimistic mode). Do you know if it will any impact about your code? By the way, it would be nice this assumed_state property set the optimistic mode automatically and save / restore the states behind the scene. |
I'm not 100% sure. Let me implement it and see what happens |
|
Assumed state seems to work nicely 👍 |
|
Tested with optimistic mode off. Verified still ok |
|
|
||
| def open_cover(self, **kwargs): | ||
| """Open the cover.""" | ||
| if self.optimistic: | ||
| self._is_opening = True | ||
| self.schedule_update_ha_state() |
There was a problem hiding this comment.
That’s to force an immediate update of is_opening?
There was a problem hiding this comment.
Realized we should probably use async_write_ha_state. Untested suggestion here #42448
Proposed change
Restore somfy state in optimistic mode on restart so shades don't get out
of sync on restart.
Device class was missing which meant all the blinds seemed like windows in the UI.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: