Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert most esphome state updates to callbacks #43246

Merged
merged 5 commits into from
Nov 15, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 15, 2020

Proposed change

Noticed while profiling: since esphome is the most active
dispatcher on many systems due to power/wifi sensors.

Nothing was being awaited in these callbacks so they
did not need to be coroutines.

Update to use self.async_on_remove

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Nothing was being awaited in these callbacks so they
did not need to be coroutines
@probot-home-assistant probot-home-assistant bot added integration: esphome small-pr PRs with less than 30 lines. labels Nov 15, 2020
@bdraco bdraco marked this pull request as ready for review November 15, 2020 00:52
@bdraco bdraco marked this pull request as draft November 15, 2020 00:55
@bdraco bdraco changed the title Decorate esphome callbacks with @callback Convert most esphome state updates to callbacks Nov 15, 2020
@bdraco bdraco marked this pull request as ready for review November 15, 2020 01:27
@balloob balloob merged commit 9d0cd9c into home-assistant:dev Nov 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants