Add new tomorrow.io integration to replace Climacell #68156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
* Add new tomorrow.io integration to replace Climacell - Part 1/3 * remove unused code * remove extra test * remove more unused code * Remove even more unused code * Feedback * clean up options flow * clean up options flow * tweaks and fix tests * remove device_class from tomorrowio entity description class * use timestep * fix tests * always use default name but add zone name if location is in a zone * revert change that will go into future PR * review comments * move code out of try block * bump max requests to 500 as per docs * fix tests
* Add new tomorrow.io integration to replace Climacell - Part 2/3 * translations * set config flow to false in manifest * Cleanup more code and re-add options flow test * fixes * patch I/O calls * Update tests/components/climacell/test_config_flow.py Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * remove unused import Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
* Switch to DeviceInfo * Add new tomorrow.io integration to replace Climacell - Part 1/3 (#57121) * Add new tomorrow.io integration to replace Climacell - Part 1/3 * remove unused code * remove extra test * remove more unused code * Remove even more unused code * Feedback * clean up options flow * clean up options flow * tweaks and fix tests * remove device_class from tomorrowio entity description class * use timestep * fix tests * always use default name but add zone name if location is in a zone * revert change that will go into future PR * review comments * move code out of try block * bump max requests to 500 as per docs * fix tests * Migrate ClimaCell entries to Tomorrow.io * tweaks * pylint * Apply fix from #60454 to tomorrowio integration * lint and mypy * use speed conversion instead of distance conversion * Use SensorDeviceClass enum * Use built in conversions and remove unused loggers * fix requirements * Update homeassistant/components/tomorrowio/__init__.py Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Use constants Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
raman325
force-pushed
the
climacell_to_tomorrowio
branch
from
f6cb193
to
1be5309
Compare
MartinHjelmare
approved these changes
Mar 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
ClimaCell as a company rebranded to Tomorrow.io and as such we will be deprecating the
climacellintegration in favor of the newtomorrowiointegration. For anyclimacellusers using a v4 API key, the migration from the old integration to the new one will happen automatically. If you are aclimacelluser using a v3 API key, you will need to sign up for a v4 API key in order to complete the migration, but once you have provided the new key, your config entry (or entries) will be migrated over automatically.For now, v3 users will still have access to their existing ClimaCell config entries before they submit the new API key so that your automations and dashboards still work. In a future release, we will be removing most of the code from the
climacellintegration so that the migrations will still happen but the original integration will no longer work.Proposed change
ClimaCell as a company rebranded to
Tomorrow.ioright around when we introduced theclimacellintegration 🙃 After consulting some other members, I decided to build a new integration which is more or less a stripped down version ofclimacell(climacell supported two different APIs, this one only supports the one that's currently supported by the company). This overall effort was split into three separate parts to make it easier to review:tomorrowiointegration. This uses a new library but the underlying code in the library is the exact same as the v4 API logic inpyclimacell. Similarly the integration logic is a simplified version of theclimacellintegration since v3 is deprecated: Add new tomorrow.io integration to replace Climacell - Part 1/3 #57121climacell: Add new tomorrow.io integration to replace Climacell - Part 2/3 #57124climacellconfig entries that are using the v4 API and semi-auto migrate ones that use the v3 API: Add new tomorrow.io integration to replace Climacell - Part 3/3 #59698This final PR merges the three PRs above into dev to finalize the introduction of the new integration.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: