-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve energy settings dialog #15205
Conversation
)} | ||
> | ||
<ha-radio | ||
value="statistic" | ||
name="costs" | ||
.checked=${this._costs === "statistic"} | ||
.disabled=${externalSource} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was wrong: A sensor or external statistics which tracks the total cost is supported both when the consumed gas is tracked by an external statistics or by a sensor. A price entity or a fixed price is only supported when the consumed gas is tracked by a sensor.
Same change for for grid and water.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @emontnemery,
I'm trying to understand why I cannot use a fixed price on external statistics but I cannot find any related documentation.
Could you please tell me where I can find more information about it? I doesn't make sense to me
Thanks!
this._source.stat_energy_from && | ||
isExternalStatistic(this._source.stat_energy_from); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check if the gas statistic is external, not if the cost statistic is external.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the change.
I didn't have the answer for your questions about external
statistics. May be @bramkragten ?
src/panels/config/energy/dialogs/dialog-energy-water-settings.ts
Outdated
Show resolved
Hide resolved
src/panels/config/energy/dialogs/dialog-energy-water-settings.ts
Outdated
Show resolved
Hide resolved
I just added the comment to explain the change, the old code was clearly wrong. |
Co-authored-by: Paul Bottein <paul.bottein@gmail.com>
Proposed change
Improve energy settings dialogs:
Screenshot:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: