Configure Renovate #15618
Configure Renovate #15618
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
Let's make sure we configure renovate to only act on the npm packages (and leave the rest up to dependabot). |
renovate
bot
force-pushed
the
renovate/configure
branch
3 times, most recently
from
374fe5b
to
af1a895
Compare
renovate
bot
force-pushed
the
renovate/configure
branch
from
af1a895
to
e76c5ab
Compare
| ":automergeLinters", | ||
| ":automergeTypes", |
There was a problem hiding this comment.
Automerge sounds like something we should never ever allow or do.
There was a problem hiding this comment.
- This is very conservative and only permits it for ESLint, Prettier, and
@types/*packages. If the CI passes, there's no reason not to merge. That's what any human would do. - It won't actually allow it anyway because the PR still requires approval per the branch protection rule. Without changes on GitHub, all it will do is effectively check the box on the PR.
Renovate has a decent discussion of the automerge feature on their website.
There was a problem hiding this comment.
This was a serious review comment which you just declined, dismissed any further discussion, added yourself, self approved and now merged.
Please revert this asap.
There was a problem hiding this comment.
That's what any human would do.
I hope for sure, that is not what any reviewer (or you) does. At least the upstream changes should be reviewed. Something renovate will not do for you, as it is not an human.
../Frenck
There was a problem hiding this comment.
I hope for sure, that is not what any reviewer (or you) does. At least the upstream changes should be reviewed. Something renovate will not do for you, as it is not an human.
I did not intend to imply that the release notes should not be reviewed. I certainly do that every time. I simply meant that in those particular cases, the CI lint is all that is needed in terms of testing.
Again, I included those rules in a way that was simply meant as an extra click time saver on a small subset of very low risk packages. No actual automatic merging was configured.
In any case, I removed all mentions of automerge in #15743.
|
Okay I think this is a good config to start with. Other than the deduplicating and "automerge" (which won't actually automerge) per my comment above, it will virtually be the same as dependabot except:
|
|
Merging to make sure this behaves like I expect. We can certainly follow up with changes. |
|
You should not have merged this. While you did not open the initial PR, the initial PR does not exist and all changes are made by you. |
|
Agree this must be reverted asap. The auto merge rules imho are a big no-go. My review comment above has just been dismissed an you just merged your own in, without any further discussion or consensus. |
| "group:monorepos", | ||
| "group:recommended", | ||
| "npm:unpublishSafe", | ||
| "workarounds:all" |
There was a problem hiding this comment.
I think this needs to be more specific, to prevent future (possibly unwanted) workarounds to just being blatantly accepted.
There was a problem hiding this comment.
Very well. I left it there as it's part of their base config. None of the workarounds are actually relevant to this repo.
I removed it in #15743.
Renovate is disabledRenovate is disabled due to lack of config. If you wish to reenable it, you can either (a) commit a config file to your base branch, or (b) rename this closed PR to trigger a replacement onboarding PR. |
|
In retrospect I should not have jumped the gun to merge. I had some time to devote to this last night and was simply eager to verify some of the configured functionality worked as expected (including automerge) before stating anything that wasn't actually correct. I meant no disrespect and had no malicious intent to dismiss or decline feedback. I don't operate that way. I intended to follow up as I stated. |
|
We know you mean well 👍 Thanks for pushing this anyways, as I think this will be a good addition 👍 ../Frenck |
Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.
🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.
Detected Package Files
package.json(npm)Configuration
🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.
Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.
What to Expect
With your current configuration, Renovate will create 21 Pull Requests:
Pin dependencies
renovate/pin-dependenciesdev7.21.07.18.67.18.67.21.07.18.67.20.77.21.07.8.37.10.47.14.57.20.27.21.06.0.22.0.176.5.12.1.03.1.18.3.55.1.1011.1.106.1.46.1.46.1.46.1.46.1.44.0.01.1.31.0.31.0.10.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.00.27.04.0.419.0.70.1.35.3.011.1.04.0.37.1.32.4.21.0.54.0.38.1.04.0.51.9.11.0.64.0.810.0.11.5.06.1.11.15.06.1.40.0.295.54.05.54.023.3.723.3.73.2.1-alpha.13.2.1-alpha.13.2.1-alpha.11.3.00.1.350.2.110.0.82.7.05.1.19.1.24.1.04.3.73.3.24.4.13.29.01.5.132.29.32.0.01.1.10.0.17.0.08.35.015.0.017.0.08.6.00.13.22.0.32.27.51.8.22.3.02.0.01.4.04.0.12.0.011.1.06.6.28.1.01.0.24.0.21.0.20.4.82.1.22.0.06.0.11.3.48.0.14.0.08.0.36.2.01.5.010.3.14.1.03.10.11.9.31.0.413.1.22.6.11.2.14.5.00.30.00.0.74.2.126.0.02.0.010.2.03.0.08.4.23.0.02.8.40.3.22.3.01.4.21.5.10.13.111.2.01.5.10.10.02.79.13.0.05.3.05.9.02.7.26.1.515.0.11.15.00.4.11.0.36.14.06.1.135.3.61.4.01.2.12.9.32.9.34.9.55.0.01.0.12.0.07.1.49.1.42.7.140.6.85.0.14.11.15.0.05.0.22.0.06.5.46.5.46.5.46.5.46.5.46.5.46.5.41.0.14Pin dependencies
renovate/codemirrordev6.4.26.2.16.6.06.3.16.2.36.2.06.9.1Pin dependencies
renovate/polymer-packagesdev3.1.03.0.13.0.13.0.13.0.13.2.13.0.13.0.13.0.13.0.13.1.03.0.13.0.13.5.1Update dependency @rollup/plugin-babel to ^5.3.0
renovate/rollup-plugin-babel-5.xdev^5.3.0Update dependency @types/chromecast-caf-receiver to v5.0.15
renovate/chromecast-caf-receiver-5.xdev5.0.15Update Yarn to v3.4.1
renovate/yarn-monorepodev3.4.1Update dependency @rollup/plugin-json to ^4.1.0
renovate/rollup-plugin-json-4.xdev^4.1.0Update dependency @web/dev-server-rollup to ^0.3.0
renovate/web-dev-server-rollup-0.xdev^0.3.0Update dependency chart.js to ^3.9.1
renovate/chart.js-3.xdev^3.9.1Update dependency webpack to v5.75.0
renovate/webpack-5.xdev=5.75.0Update dependency @rollup/plugin-babel to v6
renovate/rollup-plugin-babel-6.xdev^6.0.0Update dependency @rollup/plugin-commonjs to v24
renovate/rollup-plugin-commonjs-24.xdev^24.0.0Update dependency @rollup/plugin-json to v6
renovate/rollup-plugin-json-6.xdev^6.0.0Update dependency @rollup/plugin-node-resolve to v15
renovate/rollup-plugin-node-resolve-15.xdev^15.0.0Update dependency @rollup/plugin-replace to v5
renovate/rollup-plugin-replace-5.xdev^5.0.0Update dependency @types/chromecast-caf-receiver to v6
renovate/chromecast-caf-receiver-6.xdev6.0.8Update dependency chart.js to v4
renovate/chart.js-4.xdev^4.0.0Update dependency glob to v9
renovate/glob-9.xdev^9.0.0Update dependency rollup to v3
renovate/rollup-3.xdev^3.0.0Update dependency rollup-plugin-terser to v7
renovate/rollup-plugin-terser-7.xdev^7.0.0Lock file maintenance
renovate/lock-file-maintenancedev❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.
This PR has been generated by Mend Renovate. View repository job log here.