Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bundle chunk hashes and names #15991

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Improve bundle chunk hashes and names #15991

merged 1 commit into from
Mar 31, 2023

Conversation

steverep
Copy link
Member

@steverep steverep commented Mar 31, 2023

Proposed change

  • Switch to xxhash64 instead of default md4 (much much faster and will be webpack's future default)
  • Keep the full 64-bit hash encoded in base64url instead of hex (11 characters)
  • Use the contenthash placeholder instead of chunkhash (the former has pretty much replaced the latter and has an extra optimization flag to make sure it's a true hash of the resulting file)
  • Add the numeric id to the beginning of the non-initial chunk names (zero out any cross file collisions and so they cannot start with "-")
  • Add naming for asset modules to mimic the chunks

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@steverep steverep added the Build Related to building the code label Mar 31, 2023
@steverep steverep merged commit 91caffc into dev Mar 31, 2023
@steverep steverep deleted the webpack-xxhash branch March 31, 2023 16:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build Related to building the code cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants