Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hot reload for gallery #17484

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Remove hot reload for gallery #17484

merged 1 commit into from
Aug 4, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Aug 4, 2023

Proposed change

Gallery was using hot module reload (it uses HMR by default). It wasn't compatible with #16849.
This PR disable HMR for dev, it doesn't change anything in the dev process.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Build Related to building the code label Aug 4, 2023
@bramkragten bramkragten enabled auto-merge (squash) August 4, 2023 09:43
@bramkragten bramkragten merged commit 7dbae75 into dev Aug 4, 2023
10 checks passed
@bramkragten bramkragten deleted the fix_gallery_dev_server branch August 4, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Related to building the code cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants