Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify and compress Intl locale data #17506

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

steverep
Copy link
Member

@steverep steverep commented Aug 6, 2023

Proposed change

  1. Minify the locale data using JSON.stringify after the parse check. Also refactors the task to make the file I/O fully asynchronous. Note this also corrects an error because the call to done() was mistakenly inside the loop, so the task was moving on early.
  2. Refactor the compress task with a single glob on the whole distribution folder (both static/locale-data and static/js were being missed). Also adds CSS and SVG files into the mix.
Current Minified Compressed
14 MB 8.4 MB 1.6 MB

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file Build Related to building the code labels Aug 6, 2023
@bramkragten bramkragten merged commit 945c8e0 into dev Aug 7, 2023
10 checks passed
@bramkragten bramkragten deleted the minify-and-compress-locale-data branch August 7, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Related to building the code cla-signed Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants