Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve disabled state in more info #17570

Merged
merged 7 commits into from
Aug 15, 2023
Merged

Improve disabled state in more info #17570

merged 7 commits into from
Aug 15, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Aug 14, 2023

Proposed change

  • Improves disabled state in new more info :
    • light
    • fan
    • climate
    • humidifier
    • water_heater
  • Adds unavailable label when the state is unavailable
  • Uses shared style for more info circular slider

CleanShot 2023-08-14 at 12 28 37

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added Do Not Review PR is not ready for any kind of review and removed cla-signed labels Aug 14, 2023
@piitaya piitaya removed the Do Not Review PR is not ready for any kind of review label Aug 14, 2023
@piitaya piitaya marked this pull request as ready for review August 14, 2023 10:29
@@ -175,13 +186,16 @@ export class HaMoreInfoClimateHumidity extends LitElement {
return html`
<div class="container">
<ha-control-circular-slider
.current=${this.stateObj.attributes.current_temperature}
.current=${this.stateObj.attributes.current_humidity}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong attribute was used.

@piitaya piitaya marked this pull request as draft August 14, 2023 10:35
@piitaya piitaya marked this pull request as ready for review August 14, 2023 11:00
@bramkragten bramkragten merged commit baba02f into dev Aug 15, 2023
9 checks passed
@bramkragten bramkragten deleted the more-info-disabled-state branch August 15, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants