Add preview support to binary sensor group #17682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
commented
Aug 23, 2023
There was a problem hiding this comment.
This is 99% the same as src/dialogs/config-flow/previews/flow-preview-group_sensor.ts, what would be a good way to deduplicate them?
There was a problem hiding this comment.
We can create a base class, but that can be a follow up PR
bramkragten
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add preview support to binary sensor group
Needs core PR home-assistant/core#98872
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: