Add target temperature tile feature for climate and water heater #17697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
added
the
needs design preview
piitaya
force-pushed
the
temperature-control-tile-feature
branch
from
5f90e23
to
953cdfc
Compare
piitaya
force-pushed
the
temperature-control-tile-feature
branch
from
31d3ed3
to
6cd85a7
Compare
piitaya
changed the title
piitaya
force-pushed
the
temperature-control-tile-feature
branch
from
a6b2803
to
7f1c8ab
Compare
piitaya
force-pushed
the
temperature-control-tile-feature
branch
from
7f1c8ab
to
7d4fa1d
Compare
bramkragten
reviewed
Aug 29, 2023
| switch (e.code) { | ||
| case "ArrowRight": | ||
| case "ArrowUp": | ||
| this.value = this.boundedValue(this._value + this._step); |
There was a problem hiding this comment.
Suggested change
| this.value = this.boundedValue(this._value + this._step); | |
| this._increment(); | |
| return; |
bramkragten
reviewed
Aug 29, 2023
Comment on lines
85
to
86
| this.value = this.boundedValue(this._value - this._step); | ||
| break; |
There was a problem hiding this comment.
Suggested change
| this.value = this.boundedValue(this._value - this._step); | |
| break; | |
| this._decrement(); | |
| return; |
bramkragten
reviewed
Aug 29, 2023
Comment on lines
85
to
86
| this.stateObj!.attributes.target_temp_step || | ||
| (this.hass!.config.unit_system.temperature.indexOf("F") === -1 ? 0.5 : 1) |
There was a problem hiding this comment.
Suggested change
| this.stateObj!.attributes.target_temp_step || | |
| (this.hass!.config.unit_system.temperature.indexOf("F") === -1 ? 0.5 : 1) | |
| this.stateObj!.attributes.target_temp_step || | |
| (this.hass!.config.unit_system.temperature.includes("F") ? 1 : 0.5) |
bramkragten
previously approved these changes
Aug 29, 2023
8 tasks
bramkragten
approved these changes
Aug 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add target temperature feature for climate entity. Keyboard controls are supported when the input is focused following spinbutton keyboard interactions.
Climate target temperature
Climate target range temperature
Water heater target temperature
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: