Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hide disabled entities button #17806

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

KTibow
Copy link
Contributor

@KTibow KTibow commented Sep 3, 2023

Proposed change

Right now the button to collapse disabled entities is broken, because it uses a non-existent translation key. This fixes it to use the one that was probably intended.
How it is right now:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

How to test

Settings > integrations > open a device with hidden entities > click "+x entities not shown" > see collapse button

Additional information

All of these translations also need to be fixed (I'm not doing them because I don't know how Lokalize works):

not found event ui.panel.config.automation.editor.conditions.type.zone.event
not found traces_not_available ui.panel.config.automation.picker.traces_not_available
not found hide_disabled ui.panel.config.devices.entities.hide_disabled
not found none ui.panel.config.zwave_js.security_classes.none.title
not found state ui.panel.config.scene.picker.headers.state
not found device_entities ui.panel.config.scene.editor.entities.device_entities

no issues, discussions, or documentation is relevant here

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added this to the 2023.9 milestone Sep 4, 2023
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

There are some exclusion on keys checking https://github.com/home-assistant/frontend/blob/dev/src/common/translations/localize.ts#L8. I will look for other page 🙂

@piitaya piitaya merged commit 321f35f into home-assistant:dev Sep 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants