Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start improve restore backup in onboarding #17813

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Conversation

bramkragten
Copy link
Member

Proposed change

Take upload element out of dialog, make navigation back and forth work

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Supervisor Related to the supervisor panel label Sep 4, 2023
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have welcome link when accessing from the home page.
Also, should we have a back button when the user access from the home page?

From the home page

CleanShot 2023-09-04 at 15 33 12

Using URL parameters or refresh

CleanShot 2023-09-04 at 15 33 24

src/onboarding/ha-onboarding.ts Outdated Show resolved Hide resolved
bramkragten and others added 2 commits September 4, 2023 15:56
Co-authored-by: Paul Bottein <paul.bottein@gmail.com>
@piitaya piitaya merged commit d4872b1 into dev Sep 4, 2023
9 checks passed
@piitaya piitaya deleted the start-improve-restore-backup branch September 4, 2023 18:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants